libfprint, the fingerprint reader driver library, is nearing a 1.0 release.
Since the last time I reported on the status of the library, we’ve made some headway modernising the library, using a variety of different tools. Let’s go through them and how they were used.
When libfprint was in its infancy, Daniel Drake found the NBIS fingerprint processing library matched what was required to provide fingerprint matching algorithms, and imported it in libfprint. Since then, the code in this copy-paste library in libfprint stayed the same. When updating it to the latest available version (from 2015 rather than 2007), as well as splitting off a patch to make it easier to update the library again in the future, I used Callcatcher to cull the unused functions.
Callcatcher is not a “production-level” tool (too many false positives, lack of support for many common architectures, etc.), but coupled with manual checking, it allowed us to greatly reduce the number of functions in our copy, so they weren’t reported when using other source code quality checking tools.
This is a particularly easy one to use as its use is integrated into meson, and available through ninja scan-build. The output of the tool, whether on stderr, or on the HTML pages, is pretty similar to Coverity’s, but the tool is free, and easily integrated into a CI (once you’ve fixed all the bugs, obviously). We found plenty of possible memory leaks and unintialised variables using this, with more flexibility than using Coverity’s web interface, and avoiding going through hoops when using its “source code check as a service” model.
cflow and callgraph
LLVM has another tool, called callgraph. It’s not yet integrated into meson, which was a bit of a problem to get some output out of it. But combined with cflow, we used it to find where certain functions were called, trying to find the origin of some variables (whether they were internal or device-provided for example), which helped with implementing additional guards and assertions in some parts of the library, in particular inside the NBIS sub-directory.
0.99.0 is out
We’re not yet completely done with the first pass at modernising libfprint and its ecosystem, but we released an early Yule present with version 0.99.0. It will be integrated into Fedora after the holidays if the early testing goes according to plan.
We also expect a great deal from our internal driver API reference. If you have a fingerprint reader that’s unsupported, contact your laptop manufacturer about them providing a Linux driver for it and point them at this documentation.
A number of laptop vendors are already asking their OEM manufacturers to provide drivers to be merged upstream, but a little nudge probably won’t hurt.
Happy holidays to you all, and see you for some more interesting features in the new year.
Bastien Nocera: The tools of libfprint
Source: Planet Gnome